Jan Lübbe

Results 305 comments of Jan Lübbe

Login in done automatically by the ShellDriver (using the configured username and password). Logout is not implemented yet. Why do you need to login again during a test?

The `python3`-prefix is for python modules installed in the normal paths, so it doesn't apply here. Splitting off the coordinator is fine (due to the additional dependancies), but the other...

As POSIX host- or usernames are not allowed to contain ``/`` (and many other characters), there are likely more places in labgrid that would fail, so we can't easily change...

As the transitions are executed under ``with capsys.disabled():``, the -s switch should not be needed. Is that broken for you?

@Emantor, according to https://docs.pytest.org/en/latest/capture.html#accessing-captured-output-from-a-test-function, it should be possible to disable capturing with `capsys.disabled()`. If that's broken, we should fix it upstream instead of using `-s` as a workaround.

The [capsys docs ](https://docs.pytest.org/en/latest/capture.html#accessing-captured-output-from-a-test-function) now refer explicitly to stdout/stderr, so we need to document using `-s` in the example and with `ManualPowerDriver` under pytest.

In the medium term, I'd like to replace labgrid's powerdrivers with pdudaemon, which also has support for YKUSH (at least one of the versions). @mattface indicated that the approach to...

> Does this mean you want me to abandon this pull request? I'd prefer to go on with this to get something working in the short term, then we can...

> > > Does this mean you want me to abandon this pull request? I'd prefer to go on with this to get something working in the short term, then...

They are built using https://github.com/labgrid-project/labgrid/blob/master/.github/workflows/docker.yml. As we deploy labgrid differently (using Debian packages built via CI or via meta-labgrid), we don't really use the Docker images much and would appreciate...