Jason Quaccia

Results 22 comments of Jason Quaccia

hey @patmmccann, heads up the first pr i created turned out to be out of sync with the remote pbjs repo, so i closed it and created a new second...

Thanks @bretg sounds good, just refactored my PR based on your answer above.

Thanks @patmmccann, I still had a test HTML file that I was using to test out my changes for this issue on the PR. Just removed that file. Looks like...

Thanks @dgirardi, addressed what you mentioned above and just pushed a few more commits just now. I created a `batchRequests.init` function that now gets invoked after all batch requests have...

hey @dgirardi, thanks for the review! always appreciate your feedback 👍 💯 i went back and updated my PR and tested things locally in the browser and the logic around...

@dgirardi thank you for all the feedback! Left a few comments above

@bretg Just created a PR for this issue: https://github.com/prebid/Prebid.js/pull/8765. Had a couple of questions as well: 1. Will the response from the POST /cache call preserve the same order as...

@bretg ok thanks, that makes sense. also hoping then that point number one about ordering above is true

@dgirardi regarding currency, are further changes required for https://github.com/prebid/Prebid.js/pull/8865 or are things ok as is?

@patmmccann absolutely! Will open a PR for it soon.