scrollreveal
scrollreveal copied to clipboard
Cleanup option (and method) not working in v4.0.9
Issue
I have a demo here: https://codepen.io/Antimated/pen/gOGzpjW. The styles on my .foo
DOM element are NOT being cleaned up after the reveal. Not with the cleanup
property set to "true" nor using the afterReveal method. Am I missing something?
EDIT: Also syncing doesn't seem to work. EDIT2: Seems te broken from version 4.0.9. 4.0.8 works (cleaning works, not sure about sync)
Environment
- Operating System: MacOS
- Browser Version: Chrome Version 96.0.4664.110
- ScrollReveal Version: 4.0.9
Confirmed big on Windows Chrome and Firefox. Also both cleanup option and method work as expected in 4.0.5.
Confirmed bug on Mac Safari except clean/cleanup is broken in 4.0.8 for us as well.
The clean and destroy functions are not removing generated styles.
Same here, is there still someone who takes care of this package ?
@Aurion72 Yes, some big updates are coming soon.
If there is a problem with versions 4.0.8
and 4.0.9
, they are likely regressions introduced to get around CSP violations surfaced by manipulating inline styles directly. So perhaps rolling back to 4.0.7
is a sufficient workaround for the time being.
@Aurion72 Yes, some big updates are coming soon.
If there is a problem with versions
4.0.8
and4.0.9
, they are likely regressions introduced to get around CSP violations surfaced by manipulating inline styles directly. So perhaps rolling back to4.0.7
is a sufficient workaround for the time being.
I am very happy to hear that, I love this package, any news? :)
@Aurion72 Yes, some big updates are coming soon.
I was excited to read this but am wondering what was meant by "soon" — hopefully @jlmakes is okay!