Joan Lledó

Results 38 comments of Joan Lledó

Hello, yes, I just tried with `[email protected]` and `[email protected]` and I see the same error

I need some help to understand the context: I assume making this changes on the entry point means that the container image can be built from different Dockerfiles, that may...

> However, I do think it must be possible to remove scale somehow. Maybe making a different assertion. After all, testing updated_at changed seems to be like testing internal rails...

It's not testing Rails internals, but relying on Rails internals to perform a higher level assertion. I'll explain more in my next comment.

Rails TimeHelpers don't include all the functionality provided by Timecop: | Timecop | TimeHelpers | Comment | |--------------|-----------|------------| | `freeze` | `freeze_time` | Freezes `Time.now `at now | | `freeze(time)...

> My suggestion is to handle only assets compiled with asset_host == null. We can also edit the precompile task to fail unless it is not blank. Or better alter...

> I would say this, but I don't want you to get into conflicts. Especially the whole TS work going on recently. So I would say, add a TODO description...

I removed the webpacker update from this PR and moved it to #3083

@akostadinov @mayorova I added some comments