Johannes Link

Results 390 comments of Johannes Link

> Sorry, I deleted my comment because this does not illustrate this issue (test duration is identical between 1.8.5 and 1.9.0 in this example). It illustrates another performance issue with...

> So, to summarize, the removal of duplicated arbitrary provider, which is not desired i guess, solves the "issue". So we may probably close this issue. It would still be...

I spent a couple of hours trying to trace the differences in code execution from 1.8.5 to 1.9.0. There don't seem to be any :-/ The two things that have...

One possible next step could be to get rid of the Kotlin part in the example and see if it has anything to do with Kotlin.

Using ```kotlin @Provide fun model(): Arbitrary = Arbitraries.oneOf( anyForType(), anyForType() ) ``` speeds the code up tremendously. I conclude that the issue is somehow related to `anySubtypeOf`. Maybe there's a...

> [@jlink](https://github.com/jlink) , have you profiled the execution? I wonder if the profiler would show the key resource consumption, so we could compare it between the releases Actually no. Wondering...

> I run a profiler, and noticed this: > > I hope this will help. The percentage are aggregated time I assume. What about number of calls? If they are...

Another piece of information: The number of cache misses is the same with 1.8.5 and latest main. Let's now look at the reason why there are so many look ups...

Another insight: `MyDomain.attribute()` and `AnotherDomain.attribute()` are called in each try. Is that really necessary?

I think it is, but I'm not really sure. Then the cache misses occur because a new instance of `CombinatorScope` will be created each time.