github-codebuild-logs icon indicating copy to clipboard operation
github-codebuild-logs copied to clipboard

Published 20 hours ago • verified publisher icon jlhood

Add update instructions in README

Open trivikr opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe.

  • There are no update instructions for projects who're already using github-codebuild-logs
  • Installation instructions are in README https://github.com/jlhood/github-codebuild-logs#installation-instructions

Describe the solution you'd like Add update instructions in README

Describe alternatives you've considered Deleting application stack, and redeploying a new version

trivikr avatar Mar 16 '20 17:03 trivikr

Example difference in comments when the old application stack was deleted, and new one was deployed:

  • Old: https://github.com/aws/aws-sdk-js-v3/pull/989#issuecomment-596653632
  • New: https://github.com/aws/aws-sdk-js-v3/pull/989#issuecomment-599690213

Deleting old stack deletes links to the build logs created using older application which might be a concern for some projects. The instructions can be provided for updating the application instead.

trivikr avatar Mar 16 '20 18:03 trivikr

Confirmed that deletion of old Cloudformation stack is not required. One can just overwrite previous Cloudformation stack, and old resources will be preserved.

It would be good to have update instructions in README though.

trivikr avatar Jan 06 '21 20:01 trivikr