ClosureJavascriptFramework icon indicating copy to clipboard operation
ClosureJavascriptFramework copied to clipboard

Allow user to specify path of extracted closure-library <HOME> folder

Open lukas-vlcek opened this issue 10 years ago • 3 comments

The goal would be to allow users to keep whole closure-library sources as part of the project resources (like in vendor folder) and have it used by CJF maven testing plugin instead of built-in closure-library.

I do always keep extracted copy of closure-library as a part of the project for two reasons:

  • I implement some tests that can be run manually (by opening single HTML file) and for this I need the library sources in extracted form (these tests are also run as a part of CJF tests via maven test plugin support but it is faster if I can run individual test manually without all the maven ceremony)
  • I often look into the library sources (and my IDE allows me to quickly navigate into it)

This will also allow users to use different version of closure-library than the one provided by the CJF (there is no official maven friendly packaging anyway). This will however require user to make sure the closure-library sources are complete and valid.

WDYT? @jlgrock

lukas-vlcek avatar Jun 24 '14 13:06 lukas-vlcek

Possibly related issue: https://github.com/jlgrock/ClosureJavascriptFramework/issues/11

lukas-vlcek avatar Jun 24 '14 13:06 lukas-vlcek

I love the idea, I just don't know how best to do it. What do you think? Just point it to a directory and then copy the files over? It has to be copied over because the framework needs it for the relative pathing.

jlgrock avatar Jun 24 '14 17:06 jlgrock

I did not have a chance to check the code yet. Will look at it and get back.

lukas-vlcek avatar Jun 25 '14 08:06 lukas-vlcek