speedscope
speedscope copied to clipboard
jlfwong
UX: Timeline mouse cursor
This is related to #240. An easier way to understand that you can set the viewport in the upper part.
Up to now the mouse cursor is like in this screenshot:
It would be more intuitive if the cursor would look like this: https://www.iconfinder.com/icons/927852/cursor_design_development_drag_pointer_select_icon
Hi @guettli, thanks for the suggestion!
At present, all of the cursors used in speedscope are default browser cursors. I haven't spent any time investigating custom cursors for speedscope, but I agree this icon isn't particularly good at indicating what the interaction is going to do.
Here are the css cursor styles which are available by default: https://developer.mozilla.org/de/docs/Web/CSS/cursor
I think "crosshair" would fit: From chrome:
Ah, I originally didn't choose the crosshair one because the I thought the crosshair would suggest that the range being dragged was two dimensional. the minimap dragging only actually sets the range on a single axis though. What do you think? Maybe the crosshair is still clearer.
Yes, I think a crosshair is more intuitive. I hardly never seen the two headed arrow symbol.
@guettli I'd accept a PR to change this cursor if you'd like to do it! The relevant code is here: https://github.com/jlfwong/speedscope/blob/bdd9301c59f29c105762b6460d731438c670d705/src/views/flamechart-minimap-view.tsx#L363-L375
Sorry, my JS knowledge is limited and I have no developer to delegate this at the moment.