atom-flowmark icon indicating copy to clipboard operation
atom-flowmark copied to clipboard

No wrapping on some sentences (rare)

Open jlevy opened this issue 6 years ago • 2 comments

(See test case referenced)

jlevy avatar Jul 06 '18 20:07 jlevy

I was excited to try this package but it didn't wrap things accoring to semantic -- e.g. on commas and or other logical clauses.

Expected:

Data is what makes machine learning work.
Sure clever math solutions and optimized algorithms play an important role too,
but it's really the data that is the differentiating factor.
Specifically,
we're talking about a source of plentiful, high quality, structured, clean,
and well labelled examples of the machine learning task to be performed.

The features we use to represent each instance of a machine learning task are of central importance for the overall success of a machine learning system.
Indeed,
machine learning practitioners in the industry often describe most of the performance gains they observe come from using better features,
rather then using fancy machine learning models.
Luckily there the field of \emph{feature engineering} exists,
which consists of an arsenal of best practices and tricks for associating the most useful feature vectors as possible for each instance of the dataset.

Observed after reformat + wrap:

Data is what makes machine learning work.
Sure clever math solutions and optimized algorithms play an important role too, but it's
really the data that is the differentiating factor.
Specifically, we're talking about a source of plentiful, high quality, structured, clean,
and well labelled examples of the machine learning task to be performed.

The features we use to represent each instance of a machine learning task are of central
importance for the overall success of a machine learning system.
Indeed, machine learning practitioners in the industry often describe most of the
performance gains they observe come from using better features, rather then using fancy
machine learning models.
Luckily there the field of \\emph{feature engineering} exists, which consists of an
arsenal of best practices and tricks for associating the most useful feature vectors as
possible for each instance of the dataset.

specifically I'd expect the but it's to be on the the next line.

ivanistheone avatar Feb 27 '19 12:02 ivanistheone

@ivanistheone thanks for the note! This issue is more narrow to do with current expected behavior, which is to line break on sentences but not phrases. Moved your comment to a different issue as a feature discussion. #24

jlevy avatar Mar 17 '19 03:03 jlevy