Jonathan Lebon

Results 728 comments of Jonathan Lebon

OK, pushed more code but still working on this. Notably, one thing I realized is that we really do want to run the postprocess scripts in the Containerfile _before_ rechunking...

OK, https://github.com/coreos/fedora-coreos-config/pull/3598 should unblock this now and fix the permission issues on import. That said, hacking on this locally... I think we should just cave in and basically add `ostree-commit`...

> The patch for osbuild from this PR resolved this. Awesome! It looks sane to me. Can you open a PR against osbuild? > Now the live iso won't boot...

OK updated this now! - rebased - reworked `cosa import` to inject `ostree-commit` - we also now keep the layers blob refs in tmp/repo because that allows more efficient imports...

Overall feeling pretty good about this. I think we can get this in almost as is; there's the osbuild patch which I don't think we should carry here before opening...

> (but: we need to add GC for these in cosa prune) OK added this now! Also added a check so that we error out early if we're trying to...

Comments addressed! Also re-added the osbuild patch since it's merged upstream.

Specifically what we want is two bits from kola: 1. calling [`CheckConsole()`](https://github.com/coreos/coreos-assembler/blob/7ebc623d824bb5543754c25017dac6b40d5175af/mantle/kola/harness.go#L1920-L1953) on the console output. 2. calling [`CheckMachine()`](https://github.com/coreos/coreos-assembler/blob/7ebc623d824bb5543754c25017dac6b40d5175af/mantle/platform/platform.go#L449) on the system. That one is trickier because it takes a...

Hmm, the `lsblk` output in the "Reproduction Steps" show nothing on `/dev/sda`, but the `lsblk` output in "Other Information" does. Are you sure you're booting into the ISO and not...

Can you provide the full journal output?