pybaseball icon indicating copy to clipboard operation
pybaseball copied to clipboard
verified publisher icon jldbc

Add function to calculate vertical approach angle for Statcast Dataframes

Open GMarsh0218 opened this issue 2 years ago • 6 comments

I added a function that calculates vertical approach angle using the formula from this fangraphs article to statcast_utils.py.

GMarsh0218 avatar Feb 25 '23 07:02 GMarsh0218

Thanks! Nice add, definitely useful. Overall lgtm, just one comment and one clarification.

tjburch avatar Feb 25 '23 20:02 tjburch

I'm sorry, I don't understand what you want me to fix.

GMarsh0218 avatar Feb 26 '23 17:02 GMarsh0218

What isn't clear?

tjburch avatar Feb 26 '23 18:02 tjburch

Hey @GMarsh0218, is there anything in the code review that I can help to clarify? This is a nice addition that I'd be very happy to see merged

tjburch avatar Mar 05 '23 18:03 tjburch

I didn't understand what you meant by "just one comment and one clarification." Do you want me to add more comments to the code?

GMarsh0218 avatar Mar 07 '23 19:03 GMarsh0218

Oh, I see, my review was stuck in Pending and didn't get submitted. You should see them in-line now. Sorry about that.

tjburch avatar Mar 07 '23 20:03 tjburch