Jeremy Lloyd Conlin

Read THERMR::Card2::natom parameter from file instead of from user input

7

The `natom` parameter in Card2 of THERMR is present on the evaluation file. It should be read from the evaluation file instead of taken from the user. This should be...

Memory Leak

2

There is a memory leak. I don't know where yet. In order to find the leak, configure with ```bash cmake -D CMAKE_Fortran_FLAGD="-fsanitize=address" -D CMAKE_BUILD_TYPE=debug .. ``` Then when you run,...

How to configure to link with static option

5

If I invoke CMake with this command: make -D static_libraries=True -D static_njoy=True../ then I don't get statically linked libraries as I would think. The command `ldd` (`otool -L` on Mac)...

This is because the python can't remove the `output` and `error` file.

RECONR

1

This Pull Request adds the modern RECONR module to NJOY21.

This will create release 1.3.0. It includes modern versions of - [RECONR](https://github.com/njoy/NJOY21/pull/118) - [LEAPR](https://github.com/njoy/NJOY21/pull/127) - [THERMR](https://github.com/njoy/NJOY21/pull/144) This is a massive release---at least, the biggest release we've created so far. Because...

Maybe uninitialized variables when building with GCC in release mode

14

When building in release mode with GCC 7.3.0 (and probably other versions of GCC), several `maybe-uninitialized` errors are thrown. See below: ```shell [ 84%] Building CXX object CMakeFiles/njoy21.dir/src/main.cpp.o In file...

With the updated build system, this is no longer needed.

[NJY2016](https://github.com/njoy/NJOY2016) has many more tests than NJOY21. The tests in NJOY21 should be updated to include those of NJOY2016.