Jesse Chan
Jesse Chan
> Thank you all! This looks mostly good to me. Do we have some docs for this functionality? Only the docstrings - we don't yet have a can add a...
Would delaying adding muladd for files with experimental features make sense? Revise and muladd have been annoying for me too, but removing the muladd blocks during development has largely fixed...
I believe that the approach @andrewwinters5000 took for the shallow water equations with variable bathymetry could be adapted here. If `a(x)` doesn't depend on time, it can be represented in...
Todo: replace MHD with SWE for failing `DGMulti` SBP tests.
It should, but the difference between computed/expected errors in failing tests was larger than 1e-7. https://github.com/trixi-framework/Trixi.jl/runs/3695911625?check_suite_focus=true gives ```julia elixir_mhd_weak_blast_wave_SBP.jl (Quad): Test Failed at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:54 Expression: isapprox(l2_expected, l2_actual, atol = 1.1102230246251565e-13,...
Explicit formulas in terms of entropy variables can be found in https://arxiv.org/pdf/2109.06653.pdf
I'll try to debug it now...
> > The test failure > > ``` > > ERROR: LoadError: UndefVarError: ViscousFormulationBassiRebay1 not defined > > Stacktrace: > > [1] top-level scope > > @ ~/work/Trixi.jl/Trixi.jl/src/solvers/dgmulti/dg_parabolic.jl:208 > >...
I believe there were two others - Convergence to Euler as Reynolds's number goes to infinity - use of viscosity instead of Re I can look at the former. The...