Jacob Laursen
Jacob Laursen
> @openhab/add-ons-maintainers - does anyone know if `SLF4J_LOGGER_SHOULD_BE_NON_STATIC` is intentional or false positive? I randomly found this commit that at least documents that it was changed from static to non-static...
@alexf2015 - there are two more open comments above. I see that they are the ones GitHub has chosen to hide, so wondering if you might have missed them for...
> I was just about to change it. Meanwhile you commited the changes already. I need to signoff. Then it's done. Yes, sorry for that, I committed at the same...
@fafter82 - which value are you trying to set? QuantityType is expected: https://github.com/openhab/openhab-addons/blob/c729b82d59473f1fac871a5b18bda35f697fcc7a/bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/handler/OpenSprinklerBaseHandler.java#L73-L76 Possibly related PR, but not sure: #11816
> With regards to the build errors, it appears to be an unrelated module that is not compiling correctly (MQTT). It appears to be broken in the `main` branch as...
> > I hope you don't mind incremental review? It allows me to push some comments sooner. > No problem. I love this attention to detail, and I am learning...
@espenaf - commit c48a597c7f60815e748bf1210e1a155c1d7bf685 recently introduced some status update changes for which I posted some comments. Do you need more time for testing these late changes, or are you ready...
@clinique, @lolodomo - FYI.
@cribskip - see third chapter here: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
@andrewfg, @arroyoj - FYI.