Jacob Laursen

Results 226 comments of Jacob Laursen

> Good to see more addons using the this finder. Currently in conflict with #3943. See also discussion regarding extending the IP finder: #3936 Thanks for the links. I guess...

> Maybe we could try to merge #3943 first. For sure! This one is low priority for me, just wanted to give it a shot, since I was randomly looking...

Waiting for #4094 as well before deciding how to proceed.

> Waiting for #4094 as well before deciding how to proceed. I decided to rebase and publish, since this PR is still WIP. Either can go first.

> I am working on the wizard to select the Primary IP at the start of setup. This will mean the scan has to be done with the configured network...

> > changed broadcast address (without any changes in primary address) > > At initial setup, there would be no broadcast address configured. My thought was to only have a...

I somehow missed your reply, so responding a bit late, sorry. > As long as no broadcast address is explicitly set, it should be the default one from the primary...

@mherwege - are you okay with the current state?

> I just noticed that the broadcast finder seems to interpret the parameter `request` differently, i.e. it does not make use of pattern replacement. You implemented a new method `buildByteArray`...

@holgerfriedrich, @mherwege - I wanted to resume this work yesterday, but could not get the suggestion finder to work at all (rebased and using latest snapshot). Today I did a...