John Lapeyre

Results 216 comments of John Lapeyre

> I'm fine to merge this (or some form of it) before mine - the similar changes in mine are coincidental. Ok. Then I should 1) correct the observations you...

TY. NP. I removed one more obsolete thing today. If we had waited and kept rebasing every so often, it would have disappeared entirely!

I was calling `pi_check` on various numbers, wondering when it might return `False` or `"false"` or throw an error or something. Yes it's clear that fixing the doc string is...

EDIT: Looks like you have added parameters in the meantime. I'll check it out. This gives me an invalid syntax error. ```julia @sumtype A{T}(B{T}, B{Int}) ``` And it's clear your...

This looks super useful. Mutability: I think the data in an annotation should be immutable. In Python, you'd have trouble enforcing this. But in any case, it should be made...

This looks great for the most part. I left a few questions and suggestions.

If you are willing to rewrite your code, this may be a better workaround: https://discourse.julialang.org/t/is-this-test-detect-unbound-args-result-valid-or-a-bug/96987 The Aqua documentation on `test_unbound_args` might also mention this. The fix recommended in the docs...

I'm looking for any structural differences between `Var` and the `Qubit`/`Clbit` that might prevent using everywhere the same structures for tracking them. I don't find any yet, but may need...

I'll review this when it's ready. (The one change so far is correct. I read it before I noticed this is in draft mode.)

1. @gdalle I think you are saying that you want to separate the beginner-friendly things from the more advanced stuff. I think this is a great idea. Maybe a beginner...