bufexplorer icon indicating copy to clipboard operation
bufexplorer copied to clipboard

\bs and "Enter" on a buffer does not open the file

Open shaakaud opened this issue 9 years ago • 14 comments

Hi,

I am using zsh shell on CentOS release 6.5. I install bufexplorer plugin using vundle. I am able to list the buffers using \bs and also able to move to other buffers using up/down arrow. But when i press "ENTERY" on a particular buffer, it does not open that file instead it just goes to next line. It use to work, but suddenly i am seeing this issue. Not sure if i am missing any settings.

Uday

shaakaud avatar Jun 25 '15 23:06 shaakaud

Looks like nowait in the s:MapKeys() is causing the issue.

shaakaud avatar Jun 26 '15 00:06 shaakaud

Hi, Hum, very interesting. I will attempt to reproduce this under Debian if I can...

jlanzarotta avatar Jul 08 '15 14:07 jlanzarotta

Same issue here OSX / Bash.

youpsla avatar Jul 12 '15 00:07 youpsla

Well darn...

Strange that it works just fine under Debian with vim version 7.4.35... What versions of vim are you using? As someone mentioned before, vim version must be at least 7.3 and have the patch 1261.

jlanzarotta avatar Jul 13 '15 13:07 jlanzarotta

It works for me with 7.4.35 on OS X. ... Sorry ...

youpsla avatar Jul 13 '15 23:07 youpsla

Same problem here. OS X, Vim 7.4.712, installed with vundle

linudaar avatar Jul 30 '15 06:07 linudaar

Same here OS X Yosemite (10.10.4), Vim 7.3, installed w/ vundle

truetone avatar Jul 31 '15 17:07 truetone

I ended up creating a repo of an old version of buffer explorer that still worked and used that instead: https://github.com/crookedneighbor/bufexplorer

crookedneighbor avatar Aug 18 '15 15:08 crookedneighbor

Not exactly sure what is going on here. I will check this out and hopefully have a fix.

jlanzarotta avatar Aug 20 '15 12:08 jlanzarotta

@crookedneighbor Good idea, and thanks!

same issue with: OSX, Vim 7.3, zsh, Vundle

shwaydogg avatar Sep 03 '15 20:09 shwaydogg

I'm experienced this same issue only when I open vim from 'git config --edit' because git was opening the OSX distributed version of 'vim'. I changed my core.editor setting to '/usr/bin/env vim' which loaded the good version installed by brew.

OSX distributed version:

VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Nov  5 2014 21:00:28)
Compiled by [email protected]
Normal version without GUI.  Features included (+) or not (-):
-arabic +autocmd -balloon_eval -browse +builtin_terms +byte_offset +cindent
-clientserver -clipboard +cmdline_compl +cmdline_hist +cmdline_info +comments
-conceal +cryptv +cscope +cursorbind +cursorshape +dialog_con +diff +digraphs
-dnd -ebcdic -emacs_tags +eval +ex_extra +extra_search -farsi +file_in_path
+find_in_path +float +folding -footer +fork() -gettext -hangul_input +iconv
+insert_expand +jumplist -keymap -langmap +libcall +linebreak +lispindent
+listcmds +localmap -lua +menu +mksession +modify_fname +mouse -mouseshape
-mouse_dec -mouse_gpm -mouse_jsbterm -mouse_netterm -mouse_sysmouse
+mouse_xterm +multi_byte +multi_lang -mzscheme +netbeans_intg -osfiletype
+path_extra -perl +persistent_undo +postscript +printer -profile +python/dyn
-python3 +quickfix +reltime -rightleft +ruby/dyn +scrollbind +signs
+smartindent -sniff +startuptime +statusline -sun_workshop +syntax +tag_binary
+tag_old_static -tag_any_white -tcl +terminfo +termresponse +textobjects +title
 -toolbar +user_commands +vertsplit +virtualedit +visual +visualextra +viminfo
+vreplace +wildignore +wildmenu +windows +writebackup -X11 -xfontset -xim -xsmp
 -xterm_clipboard -xterm_save
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -D_FORTIFY_SOURCE=0 -Iproto -DHAVE_CONFIG_H -arch i386 -arch x86_64 -g -Os -pipe
Linking: gcc -arch i386 -arch x86_64 -o vim -lncurses

brew installed version:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Sep 13 2015 23:14:36)
MacOS X (unix) version
Included patches: 1-865
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +syntax
+arabic          +file_in_path    +mouse_sgr       +tag_binary
+autocmd         +find_in_path    -mouse_sysmouse  +tag_old_static
-balloon_eval    +float           +mouse_urxvt     -tag_any_white
-browse          +folding         +mouse_xterm     -tcl
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+cindent         -gettext         -mzscheme        +textobjects
-clientserver    -hangul_input    +netbeans_intg   +title
+clipboard       +iconv           +path_extra      -toolbar
+cmdline_compl   +insert_expand   +perl            +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python          +viminfo
+cscope          +lispindent      -python3         +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      -lua             +rightleft       +windows
+diff            +menu            +ruby            +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      -sniff           -xsmp
+eval            +mouse_dec       +startuptime     -xterm_clipboard
+ex_extra        -mouse_gpm       +statusline      -xterm_save
+extra_search    -mouse_jsbterm   -sun_workshop    -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: /usr/bin/clang -c -I. -Iproto -DHAVE_CONFIG_H   -F/usr/local/Frameworks -DMACOS_X_UNIX  -Os -w -pipe -march=native -mmacosx-version-min=10.10 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: /usr/bin/clang   -L. -L/Users/welchg/.rbenv/versions/2.2.2/lib  -fstack-protector -L/usr/local/lib -F/usr/local/Frameworks -Wl,-headerpad_max_install_names -o vim        -lm  -lncurses -liconv -framework Cocoa   -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl -framework Python   -lruby-static -framework CoreFoundation -lobjc -L/Users/welchg/.rbenv/versions/2.2.2/lib

sanscore avatar Sep 23 '15 15:09 sanscore

Maybe there is a change that affected one of the later patches in 7.3!? If so, that would make recent bufexplorer dependent on that patch (assuming one exists).

Looking at: http://ftp.vim.org/pub/vim/patches/7.3/

The following patches mention 'wait' 7.3.499, 7.3.1179, 7.3.1264, and 7.3.1309.

It looks like everyone except linudaar was using vim 7.3 when they experienced the issue. Maybe we can get people to run the following commands.

:echo has('patch-7.3.499')
:echo has('patch-7.3.1179')
:echo has('patch-7.3.1264')
:echo has('patch-7.3.1309')

Which will echo either '0' (patch not installed) or '1' (patch installed).

It looks like the OSX distributed version that I used doesn't have any patches at all. It looks like it is straight 7.3.

sanscore avatar Sep 23 '15 18:09 sanscore

Yeah, something is definitely wrong. When I revert back to the bufexplorer 7.2.8, everything works just fine. I am currently in the process of taking 7.2.8 and updating it and seeing what happens...

jlanzarotta avatar Sep 23 '15 20:09 jlanzarotta

Based on the descriptions, it looks like patches 1261 and 1264 are necessary to get bufexplorer to work properly with .

http://ftp.vim.org/pub/vim/patches/7.3/7.3.1261 http://ftp.vim.org/pub/vim/patches/7.3/7.3.1264

I checked the history of the project and found these: https://github.com/tpope/vim-surround/issues/98#issuecomment-77435471 https://github.com/jlanzarotta/bufexplorer/pull/33 https://github.com/jlanzarotta/bufexplorer/issues/36

I think your explanation in the last link is satisfactory for me. People can use an old version, or a fork, or upgrade vim. Anyway, it works for me.

sanscore avatar Sep 23 '15 20:09 sanscore