EasyImage icon indicating copy to clipboard operation
EasyImage copied to clipboard

EasyImage.willHandleActivityResult need update

Open java1developer opened this issue 6 years ago • 1 comments

as return (requestCode & 876) > 0;

java1developer avatar Jul 19 '18 03:07 java1developer

Agree the title. The current code will always return false if developers don't add requestCode &= -32769; before EasyImage.willHandleActivityResult(requestCode, resultCode, data).

I think the code should be like:

public static boolean willHandleActivityResult(int requestCode, int resultCode, Intent data ) {
    boolean isEasyImage = (requestCode & RequestCodes.EASYIMAGE_IDENTIFICATOR) > 0;
    if (!isEasyImage) {
        return false;
    }
    requestCode &= ~RequestCodes.SOURCE_CHOOSER;
    if (requestCode == RequestCodes.PICK_PICTURE_FROM_GALLERY ||
            requestCode == RequestCodes.TAKE_PICTURE ||
            requestCode == RequestCodes.CAPTURE_VIDEO ||
            requestCode == RequestCodes.PICK_PICTURE_FROM_DOCUMENTS) {
        return true;
    }
    return false;
}

RJHsiao avatar Aug 04 '18 06:08 RJHsiao