John Watson

Results 328 comments of John Watson

The package size has nothing to do with compiled vs. dynamic. If we have class files that represent the constants (like we today), then the semconv package will continue to...

I don't think we have a spec for exactly how all of this is supposed to work yet.

If you have access to a windows dev machine and can put in a PR to fix this, that would be great. None of the maintainers have one at this...

> Hmm. Apparently, I cannot assign it to myself. Can you grant me permissions and add me to contributors? assigned to you.

Hi @pavolloffay . Can you have an exporter wrapper that updates the SpanData to filter out what you don't want? Or, alternatively, have a SpanProcessor wrapper that does the same...

@pavolloffay last chance to respond or I will close this as not needed at this time.

@FrankSpitulski I recommend doing this in an exporter, rather than trying to do it in a `SpanProcessor`. That interface was not designed for mutating spans when they end.

This was introduced at the request of @Oberon00 to support lambda usages. Additional documentation as to 'why' would be good.

Looking at this carefully, the `@Nullable` annotation on the `Getter` might not make sense any more, since the `Getter` is no longer a single-method interface, and hence can't be implemented...

@carlosalberto can this now be closed with the 2 merged PRs?