John Watson comments

Results 328 comments of


                                            John Watson

Provide optional attributes in SpanBuilder chains

Just my 2 cents, as a maintainer: although the behavior is documented as "undefined", currently we drop any null-valued attributes. It's "undefined" because the spec doesn't specify what the behavior...

[OpentracingShim] Support returning non-null SpanContextShim in `Propagation.extractTextMap` when traceId and SpanId are not present in OTel SpanContext

paging @carlosalberto

Can Sampler#shouldSample method add a param `InstrumentationScopeInfo`?

We can figure out how to add this only if it added to the official otel specification.

Support large number of metric data points by reducing memory allocation

I'm not opposed to changing the internal approach to the way the SDK does exports. Would you have the time to create a PR for this change, @asafm ?

Ability to update baggage from SpanProcessor

This would need to go through the specification before we would implement it unilaterally in Java. Please open an issue in the specification repository for this change.

Ability to add span attributes in SpanProcessor's onEnd operation

This would need to go through the specification before we would implement it unilaterally in Java. Please open an issue in the specification repository for this change.

Is there a way to let trace exporter to export all the spans to OTel agent/collector regardless of the sampled flag in the spans' are 0/1 and let OTel agent/collector to make the decision based on the spans' sampled flag?

This would need to be added to the specification if we were to implement it in Java. Please raise this as an issue in the specification repository. Thanks!

ClassNotFoundException io.grpc.ManagedChannel using the OtlpGrpcMetricExporter in clojure.

@jack-berg good to know that the groovy classloader breaks things...but this question is about clojure. Perhaps it also does some classloading shenanigans?

Equivalent of "logLevel" for spans

> > Yes, it is possible to adjust tracing levels in OpenTelemetry for Golang to control which spans are exported at what level. OpenTelemetry provides several levels of tracing that...

Manage dependency on grpc-netty-shaded

> The exception is coming from here (the component that uses grpc): > > ``` > at io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder.build(OtlpGrpcSpanExporterBuilder.java:129) ~[opentelemetry-exporter-otlp-trace-1.0.0.jar:na] > ``` > > It's [`compileOnly`](https://github.com/open-telemetry/opentelemetry-java/blob/11fcc29b0a4f7c48ae9e5846d38587373ea299f4/exporters/otlp/trace/build.gradle.kts#L22-L23) in OTel, I'm not sure...