MakieLayout.jl icon indicating copy to clipboard operation
MakieLayout.jl copied to clipboard

Published 20 hours ago • verified publisher icon jkrumbiegel

Some changes for WilkinsonTicks

Open asinghvi17 opened this issue 4 years ago • 3 comments

asinghvi17 avatar Mar 13 '20 10:03 asinghvi17

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   60.07%   60.07%           
=======================================
  Files          26       26           
  Lines        2074     2074           
=======================================
  Hits         1246     1246           
  Misses        828      828
Impacted Files Coverage Δ
src/types.jl 94.87% <ø> (ø) :arrow_up:
src/ticklocators/wilkinson.jl 87.5% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06939fa...a8abded. Read the comment docs.

codecov-io avatar Mar 13 '20 10:03 codecov-io

did you test it with strict = false? I just checked and that causes ticks outside of the given limits for me

jkrumbiegel avatar Mar 13 '20 12:03 jkrumbiegel

Interesting, I'd tried it before and it seemed to work. Will turn it on if that's the case.

asinghvi17 avatar Mar 13 '20 12:03 asinghvi17