helm-secrets icon indicating copy to clipboard operation
helm-secrets copied to clipboard

#249 add --sopsjson option to specify additional json files t decrypt…

Open diepes opened this issue 2 years ago • 0 comments

… when running helm secrets

What this PR does / why we need it: adds flag --sopsjson. <file.json> Allows the wrapper to also decrypt json files. Usage: Json config file that is not parameterized with helm values, that needs to go into a k8s secret. e.g. chart/files/configs/config_sensitive.json In the tempate/secrets.yaml we then .Files.get config_sensitive.json.dec

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # #249

Special notes for your reviewer: Works similar to --values (Tried to share the code) main difference is that it does not add the --sopsjson <file.json> to the command line that is passed to helm.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [ ./ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

diepes avatar Aug 10 '22 11:08 diepes

I'm thinking maybe the flag should be more generic. --sops-extra Then we can check for the file extension to decide if it is json or yaml, maybe in the future even a directory.

diepes avatar Aug 11 '22 05:08 diepes

@diepes please take a not about https://github.com/jkroepke/helm-secrets/issues/249#issuecomment-1212044056

jkroepke avatar Aug 12 '22 07:08 jkroepke

Closing as this can be accomplished by future --set-file option.

diepes avatar Sep 06 '22 06:09 diepes