node-iconizr icon indicating copy to clipboard operation
node-iconizr copied to clipboard

Published 20 hours ago • verified publisher icon jkphl

Different size icons not being handled correctly

Open pfiaux opened this issue 10 years ago • 5 comments

I tried generating a sprite sheet with a set of icons that have different sizes. This worked correctly on the online version of iconizr (they all get scaled down to the specified size). In the node version the generated spritesheet was messed up in different ways:

  • The large ones scaled to the size defined.
  • The small ones scaled with a similar factor as the large ones rendering them really small.
  • The offsets generated in the sprite sheet and the less/css were inconsistent. For 32px there was offsets of 8px or even odd numbers like 17px.
  • Possibly as a side effect of the issues above the png sprite sheet generated all blank (but it has the correct size).

Is there a way to handle different sizes or is this a limitation?

pfiaux avatar Jul 25 '14 06:07 pfiaux

Hi @pfiaux,

thanks for report. I'd like to ask you to provide all the files involved as well (SVG sources, generated SVG sprite and PNG sprite). Please send them to joschi [at] kuphal [dot] net — thanks!

Also, please note that the online version at iconizr.com is based on the original PHP version and quite outdated at the moment (the Node version has far more features and options to consider).

Unfortunately, due to limited resources, I won't be able to work on your request in the next couple of days, so please don't expect me to be too fast! Sorry for that.

Cheers, Joschi

jkphl avatar Jul 25 '14 06:07 jkphl

I thought the site might be running the PHP version, since i noticed that was indeed more options in node. This is why i'm confused that it behaves differently on the same icon set. Files on the way.

pfiaux avatar Aug 06 '14 06:08 pfiaux

@jkphl did you find time to have a look at the issue already?

Red-nothing avatar Aug 25 '14 08:08 Red-nothing

@Red-nothing Sorry, no, not yet! :( I'm so totally overloaded at the moment that there is no time for working on side projects right now. Thanks for your patience!

jkphl avatar Aug 25 '14 08:08 jkphl

Hi @pfiaux & @Red-nothing,

just wanted to let you know that I didn't forget your issue! I'm going to start a rewrite of iconizr during the next days and will ensure that your assets render correctly in the new version!

Cheers & happy new year, Joschi

jkphl avatar Jan 02 '15 13:01 jkphl