boardgame icon indicating copy to clipboard operation
boardgame copied to clipboard

Improve errors messages when golden fails to compare

Open jkomoros opened this issue 6 years ago • 2 comments

Debugging a broken game in the other repo broken by 76af12a (which is part of #458) is a pain because when the move doesn't match it's not clear why.

Ideally we'd print out the log only when that error happens.

jkomoros avatar Oct 31 '18 16:10 jkomoros

  • [x] fix bug in out-of-repo pass game caused by 76af12a692012363690259eb7a1f4ababbb97c32
  • [ ] More descriptive error messages about what was expected and what was gotten

jkomoros avatar Oct 31 '18 16:10 jkomoros

The bug introduced in 76af12a is that dealActionHelper doesn't return destination, source, it returns playerState, gameState. For deal components that's destination / source, but for collect components moves it's source / destination.

jkomoros avatar Oct 31 '18 16:10 jkomoros