boardgame icon indicating copy to clipboard operation
boardgame copied to clipboard

Shouldn't move.LegalPhases() just be a single phase?

Open jkomoros opened this issue 6 years ago • 0 comments

Noticed while fixing #646.

It used to be that a single move could be legal in multiple phases. But now with treeenum phases, it seems like it should only be a single legal phase.

Logic in for example moves historicalMovesSincePhaseTransition for example seems to implicitly rely on there only being one legal phase for a given move.

jkomoros avatar Oct 20 '18 14:10 jkomoros