CASsim icon indicating copy to clipboard operation
CASsim copied to clipboard

Test on mobile

Open jkomoros opened this issue 3 years ago • 1 comments

jkomoros avatar Nov 26 '21 22:11 jkomoros

  • [x] And on Firefox and desktop safari
  • [x] Safari: SVG renders clipped at beginning... until run changes via animation only
  • [x] frame-vizualization should get its height/width set in some way based on available size (at the same aspect ratio as width/height)
  • [x] Make configuartionExpanded by a proeprty in state (not just implied in the DOM of the configuration-controls), and when it changes, call resizeVisualization()
  • [x] When configuration_expanded is true, offset with a margin (it's still possible for it to overlap)
  • [x] When screen size is very small and config is not open, and the width overlaps with the collapsed controls, give a margin-top to frame visualization to not overlap it (could currently happen on very small phone screens)
  • [x] Don't show the fork me on github on moblie (?)
  • [x] Padding should be percentage of overall width
  • [x] When screen size is very small, do a margin-left as well (since it overlaps even if it's closed)
  • [ ] Add a rotate phone overlay (like card-web) if the phone is rotated differently than the aspect ratio of the visualization
  • [x] Help icon on firefox/safari is highlighted
  • [ ] Hide the fork on github on mobile screens
  • [x] Make sure that the screenshotting machinery outputs frames at the exact pixel size and height (and document that that's what that means)
  • [x] When controls.showing, page size, or width or height changes, recalculate a new scale for the SVG (verify screenshotting still works at expected width/height size of screenshot)
  • [x] SVG should set a viewbox based on width and height so it sizes appropriately as container is scaled proportionately
  • [x] Safari: SVG rendering of selected vs not selected project doesn't work (svg filter?)

jkomoros avatar Nov 30 '21 03:11 jkomoros