handlebars.java icon indicating copy to clipboard operation
handlebars.java copied to clipboard

Inline partial leak - additional scenario

Open dudabone opened this issue 5 years ago • 5 comments

In continuance to issue #655 , there is still a scenario in which it can be reproduced in my production application. The scenario is quite complex, but it is real and I was able narrow down the reason to a combination of 3 levels of inheritance, where the 1st level ("section1") calls two partials with the same base ("inputs-wrapper1" and "inputs-wrapper2" - 2nd level), with some other template between these two ("inputs-wrapper-separator"). I tried to simplify the scenario as much as I can here, I hope this makes some sense. The main template is "form.hbs".

You can see that the expected result (expected.txt) is that section 2 will be empty (except from what is inherited from base-section.hbs), but what really happens (actual.txt) is that the content of section 1 completely "leaks" to section 2.

Please let me know if I can assist with anything

dudabone avatar Oct 30 '18 14:10 dudabone

there is no zip file (can't download)

jknack avatar Oct 31 '18 14:10 jknack

sorry, fixed

dudabone avatar Oct 31 '18 15:10 dudabone

Hi @jknack, just making sure you saw that I updated the issue with the correct example file. Thanks

dudabone avatar Dec 22 '18 01:12 dudabone

I found the issue, but not sure how to fix it yet. It requires time and feel is going to break something else :S

jknack avatar Jan 08 '19 14:01 jknack

Hi @jknack , do you think that you will get to fixing this some time in the near future?

dudabone avatar Jun 18 '19 19:06 dudabone