handlebars.java icon indicating copy to clipboard operation
handlebars.java copied to clipboard

Add spring-webflux compatibility to handlebars-springmvc (#642)

Open shortstories opened this issue 6 years ago • 7 comments

  • update spring version (3.1.1.RELEASE -> 5.0.7.RELEASE)
  • add spring-webflux
  • update Junit version (4.11 -> 4.12)
  • add handlebar spring reactive view and view resolver
    • ReactiveHandlebarsView
    • ReactiveHandlebarsViewResolver
    • And their tests...

shortstories avatar Jul 25 '18 09:07 shortstories

Codecov Report

Merging #647 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #647      +/-   ##
============================================
- Coverage     87.33%   87.28%   -0.05%     
+ Complexity      841      833       -8     
============================================
  Files            78       78              
  Lines          3023     2989      -34     
  Branches        411      407       -4     
============================================
- Hits           2640     2609      -31     
+ Misses          261      260       -1     
+ Partials        122      120       -2
Impacted Files Coverage Δ Complexity Δ
...knack/handlebars/helper/DefaultHelperRegistry.java 74.48% <0%> (-2.15%) 20% <0%> (-2%)
...hub/jknack/handlebars/internal/FormatterChain.java 85.71% <0%> (-1.79%) 4% <0%> (-1%)
...ain/java/com/github/jknack/handlebars/Context.java 94.68% <0%> (-0.2%) 37% <0%> (ø)
...ub/jknack/handlebars/internal/TemplateBuilder.java 88.15% <0%> (-0.04%) 88% <0%> (ø)
...com/github/jknack/handlebars/internal/Partial.java 93.27% <0%> (+1.48%) 31% <0%> (-5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f45894...f142a6b. Read the comment docs.

codecov-io avatar Jul 25 '18 10:07 codecov-io

Coverage Status

Coverage remained the same at 91.301% when pulling f142a6b9a69644342fd5aabcec73a7cd9ff86b56 on shortstories:master into 3b702a4a8ffeb07e52867fdf1ab69c9c414ae973 on jknack:master.

coveralls avatar Jul 25 '18 10:07 coveralls

Looks good with one question.

Is Spring 5.x compatible with 3.x?

I know 3.x is old (very old) but don't want to break existing integrations

jknack avatar Jul 26 '18 12:07 jknack

I created a Spring3 test project (https://github.com/shortstories/spring3-mvc-maven-xml-hello-world) and tried to run it. It works without problems.

shortstories avatar Jul 30 '18 08:07 shortstories

@jknack any chances this PR could be revitalized, so that Spring Webflux with Handlebars becomes available?

nikos avatar May 15 '20 12:05 nikos

Codecov Report

Merging #647 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #647   +/-   ##
=========================================
  Coverage     87.28%   87.28%           
  Complexity      833      833           
=========================================
  Files            78       78           
  Lines          2989     2989           
  Branches        407      407           
=========================================
  Hits           2609     2609           
  Misses          260      260           
  Partials        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b702a4...f142a6b. Read the comment docs.

codecov-commenter avatar Sep 11 '20 07:09 codecov-commenter

HI! how i can help for push it to master? Because it's really actual for me)

IRuzhnikov avatar Sep 21 '22 09:09 IRuzhnikov