handlebars.java icon indicating copy to clipboard operation
handlebars.java copied to clipboard

4.4.0 breaks Java 8 support

Open theangrydev opened this issue 10 months ago • 4 comments

.m2/repository/com/github/jknack/handlebars/4.4.0/handlebars-4.4.0.jar(com/github/jknack/handlebars/Context.class) [ERROR] class file has wrong version 61.0, should be 52.0

theangrydev avatar Apr 17 '24 08:04 theangrydev

It seems the Java baseline was changed here: https://github.com/jknack/handlebars.java/commit/70d9261cf133969d373614d89e3e05cebb6f289c. As a user of handlebars and a maintainer of a project (micrometer-docs-generator) that uses it, I find quite unfortunate that the Java baseline was changed in a minor version and that the release notes does not mention this rather important detail.

jonatan-ivanov avatar Jul 03 '24 22:07 jonatan-ivanov

It breaks a lot. "Upgrade to Spring 6" means javax -> jakarta! That should have been a major version bump!

nealeu avatar Jul 12 '24 10:07 nealeu

I think it is still possible to fix this by re-releasing

  • 4.3.1 as 4.5.0
  • 4.4.0 as 5.0.0

@jknack what do you think?

jonatan-ivanov avatar Jul 13 '24 01:07 jonatan-ivanov

The above suggestion is a really good idea. It's relatively simple to execute, and would clean up a lot of dependabot failures.

And, many thanks for providing us with a great Handlebars library. It is much appreciated!

nealeu avatar Jul 13 '24 15:07 nealeu