scimax icon indicating copy to clipboard operation
scimax copied to clipboard

Spelling

Open jsoref opened this issue 2 years ago • 3 comments

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/scimax/actions/runs/4870186792#summary-13196829839

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/scimax/actions/runs/4870186748#summary-13196830541

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

This is a follow-up to #451. I've mostly performed a rebase for the fixes, there were only a couple of items that were new.

If you'd like me to drop things in "deprecated" or other paths, please let me know. I'm more than happy to drop things. If at some point you actually like the changes, I'm quite happy to squash the commits together. I do not squash eagerly as I assume that people will find at least some of my changes controversial.

Note that for this, I redid the work to calculate which things to ignore (the engine for check-spelling has improved significantly since the previous PR).

jsoref avatar May 03 '23 09:05 jsoref

I probably should have noted i fixed these on the homebrew branch, and will eventually merge that onto the master branch.

How do you run this spell check?

jkitchin avatar May 03 '23 13:05 jkitchin

Oh!

I apply this commit: https://github.com/jsoref/scimax/commit/21de372d72d5ec167b654218eb2909458e1ba658 Or more accurately, I apply a series of commits and iterate: https://github.com/check-spelling/scimax/actions/workflows/spelling.yml

jsoref avatar May 03 '23 13:05 jsoref

Ok, I've rebased the commits onto the homebrew branch. And I pushed a rebased https://github.com/jsoref/scimax/tree/spell-check branch with https://github.com/jsoref/scimax/commit/9731f2c296157bb0fa7ad33adc36e08b973552e7 which generated https://github.com/jsoref/scimax/actions/runs/4872848445#summary-13204517578 which is what I'd look at if I were starting again (I'm not doing another run this morning, I need to go into the office and work on my day job things).

If you'd like to use the workflow or have any questions, I should be able to respond tonight or tomorrow night.

Thanks for the prompt feedback and have a great day.

jsoref avatar May 03 '23 14:05 jsoref