fb-friends-bookmarklet icon indicating copy to clipboard operation
fb-friends-bookmarklet copied to clipboard

Doesn't work anymore

Open dancsi opened this issue 11 years ago • 3 comments

The bookmarklet does not work anymore. It fails with an

Uncaught TypeError: Cannot read property 'entries' of null

dancsi avatar Dec 25 '13 18:12 dancsi

I have two issues, neither of which is the one above...

  • the bookmarklet is too long - after converting spaces to %20s Firefox truncates the bookmarklet at 65,536 characters - quite a bit short of the 95,472 characters it needs for the whole thing.

  • even if I copy and paste the code from here into the console, I get

    TypeError: r.payload is null

    and the number 9 printed after that.

spiralx avatar Dec 23 '14 01:12 spiralx

thanks for the comments. havent been able to take a look at this / update it in a while so it seems like it is likely broken now .. especially with all the changes fb makes. open to pull requests and maybe i can take a look at it in the future

On Mon, Dec 22, 2014 at 5:23 PM, James Skinner [email protected] wrote:

I have two issues, neither of which is the one above...

  • the bookmarklet is too long - after converting spaces to %20s Firefox truncates the bookmarklet at 65,536 characters - quite a bit short

    of the 95,472 characters it needs for the whole thing.

    even if I copy and paste the code from here into the console, I get

    TypeError: r.payload is null

    and the number 9 printed after that.

— Reply to this email directly or view it on GitHub https://github.com/jkeesh/fb-friends-bookmarklet/issues/3#issuecomment-67912329 .

jkeesh avatar Dec 23 '14 07:12 jkeesh

I've spent time fixing old bookmarklets before, but yours is huge, and would require that I learn the Graph API properly ;) It was nifty though, back before browsers started cracking down on random bits of code injected into the page.

You might want to update your site though, you're #1 and #2 on Google for "Facebook Friends Finder".

spiralx avatar Dec 23 '14 14:12 spiralx