jk icon indicating copy to clipboard operation
jk copied to clipboard

Can the jkcfg/build image use jkcfg/prebuilt?

Open squaremo opened this issue 4 years ago • 5 comments

This would speed it up a bit.

squaremo avatar Mar 31 '20 20:03 squaremo

I originally used the docker image to generate the linux prebuilt binaries as a way to have reproducible builds that don't depend on the developer environment. That said we could have two dockerfiles, one to build things, one using the prebuilt?

dlespiau avatar Apr 01 '20 07:04 dlespiau

Ah, so something like,

jkcfg/prebuild -> builds or downloads all binaries etc. for prebuilt
jkcfg/build -> uses prebuilt for jk build

(OK the prebuild v. prebuilt would be confusing, but with different names ...)

squaremo avatar Apr 01 '20 07:04 squaremo

Yes! That's precisely what I had in mind :)

dlespiau avatar Apr 01 '20 08:04 dlespiau

Actually the prebuilt repo could host the prebuild Dockerfile, then the build image could just copy the bits out of the prebuild image. And we should probably use specific digests when we refer to images.

squaremo avatar Apr 01 '20 08:04 squaremo

Ah yes, even better!

dlespiau avatar Apr 01 '20 08:04 dlespiau