jkalias

Results 58 comments of jkalias

What would you think of another approach: keeping track of which initializer was used like this ```swift public struct Angle { public var radians: T { switch input { case...

> A few thoughts: > > Why is there a constraint to `BinaryFloatingPoint`? Is `Real` not sufficient? True, it's removed now. Can't remember why I put it there in the...

I tried to address all issues which came up during the previous round of discussion. 1. Degrees and radians are stored separately, so ```Angle(degrees: 20) + Angle(radians: .pi)``` will accurately...

> I’m not convinced storing both degrees and radians separately is worthwhile. I would lean more toward a design that stores a value (of type `T`) and a unit (probably...

Hello and happy/healthy new year to everybody. It's not clear to me if there is something I need to do here, or if people are still thinking about it. Any...

I am all in for radians in numerical code. However, judging from previous comments, it seems that the community does not accept inaccuracies for degrees inputs (eg. `cos(Angle(degrees: 90)) !=...

I think we need to first answer what @danieljfarrell mentioned: what is the primary use case of swift-numerics and what is the target audience. According to the introduction section, "Swift...

Fair enough. I currently see the following options moving forward: 1. I pause this PR and step down till @stephentyrone (or someone else ?) has more time to implement his...

I’m not sure I fully understand what is meant here. a. An `Angle` type should not be defined in swift-numerics because it’s not in the intended scope of the library....

Following the previous discussions, I made an attempt this time using the trig-pi functions introduced in branch #85. I still don't have a working method for a _correct_ argument reduction...