Gradle-License-Report
Gradle-License-Report copied to clipboard
Add/Fix lingering Task property annotations
What does this PR do?
- Add/Fix lingering Task property annotations that are causing build issues
-
CacheableReportTask.groovy- Apply the
@ClassPathnormalization strategy to theclasspathtask property
- Apply the
-
CheckLicenseTask.groovy- Declare
configas a@Nestedtask property - Apply the
ABSOLUTEpath sensitivity toallowedLicenseFiletask property - Apply the
ABSOLUTEpath sensitivity toprojectDependenciesDatatask property
- Declare
-
LicenseReportExtension.groovy- Apply annotations to properties that tasks use transitively
- Declare
renderersas a@Nestedtask property - Remove
renderersexplicitpublicvisibility modifier to make the validator happy - Declare
rendereras a@Nestedtask property - Increase the visibility of the
licenseReportExtensionSnapshottask property topublic(fromprivate) to leverage the existing@Inputannotation
- Declare
- Apply annotations to properties that tasks use transitively
-
Why was this PR opened?
The build is currently failing due to the validatePlugins task failing. Some changes were made in #159 to resolve Gradle 6.0 deprecations, which resulted in the resolution of #162, but it looks like there were a handful of lingering issues with task annotations after the integration of those changes. This PR fixes the remaining issues that are causing the build to fail
Are there changes in the PR that require closer review?
-
LicenseReportExtension.groovy- Should the visibility of
licenseReportExtensionSnapshotbeen increased, or annotation removed? I couldn't find any usage of it.
- Should the visibility of
-
CheckLicenseTask.groovy- Is
ABSOLUTEpath sensitivity ok for theallowedLicenseFileandprojectDependenciesDatatask properties?
- Is
Does this PR meet the usual acceptance criteria?
- [x] Project Builds
- [x] Tests pass
- [x] Document generates successfully with no errors or warnings
Related Issues / PRs
- #159
- #162
Could you resolve the conflicts?