wvkbd icon indicating copy to clipboard operation
wvkbd copied to clipboard

add desktop layout from user nine7nine as independent layout

Open FearlessSpiff opened this issue 11 months ago • 6 comments

This adds the layout from user nine7nine as described in https://github.com/jjsullivan5196/wvkbd/issues/54. See screenshot (athough with my own dracula theme which is not part of this MR)

20240318_18h02m24s_grim

FearlessSpiff avatar Mar 18 '24 17:03 FearlessSpiff

@FearlessSpiff - this is a surprise. I've been a bit busy, and I was just about to reply on the other issue I opened up about this... I really haven't had the time to get back to doing this myself; so if you are on top of it: that is cool with me. Just credit my part of it in the commit, and we are good!

One thing though: this layout still needs some fine-tuning. some of the floating point size/scaling is a bit off (that's why you don't have perfectly straight lines on the left/right sides... and obviously: i added a bit of spacing that matched my own hyprland layout.

these are pretty minor details that can be fixed up though.

nine7nine avatar Mar 18 '24 18:03 nine7nine

One thing though: this layout still needs some fine-tuning. some of the floating point size/scaling is a bit off (that's why you don't have perfectly straight lines on the left/right sides... and obviously: i added a bit of spacing that matched my own hyprland layout.

Lol, had Ctrl pressed on wvkbd, thus the edit...

I couldn't even see this until you mentioned it and I zoomed in on my screenshot! :-D

FearlessSpiff avatar Mar 18 '24 18:03 FearlessSpiff

just installed iio-hyprland and there seams to be a problem in horizontal orientation.

FearlessSpiff avatar Mar 18 '24 20:03 FearlessSpiff

@FearlessSpiff - yeah, it's hard to notice the alignment issue, unless looking for it. Maybe on the weekend if i have time i will try to clean up the layout. Fix that stuff... it was one of those things; i was totally unfamiliar with the code, played around until i had a usable layout,then got busy with other things.

As far as iio-hyprland. I can't get auto-rotate to work at all on my Microsoft Surface 7. I have a button/widget for rotate -- and wvkbd works fine with both orientations for me. What is the issue exactly?

nine7nine avatar Mar 18 '24 20:03 nine7nine

@nine7nine I don't know exactly. One time it worked. The other time the buttons weren't where they were supposed to be and then the layout got all messed up. I will have to further test this. Maybe it is also an issue with -mobintl layout. But atm I am at work ;)

FearlessSpiff avatar Mar 19 '24 07:03 FearlessSpiff

Thanks! It took a while before I got to it, but I just tried the layout and it looks pretty good!

Just credit my part of it in the commit, and we are good!

This was my first thought as well; I understand this comes from @nine7nine's fork with additional improvements by @FearlessSpiff on top. Right now the commit history in this PR doesn't reflect this though.

@FearlessSpiff: Could you rebase the PR so the original commits are as they were (carrying the proper Author for attribution)? And then yours on top of that? (you might still have them in your working tree)

One thing though: this layout still needs some fine-tuning. some of the floating point size/scaling is a bit off (that's why you don't have perfectly straight lines on the left/right sides..

I didn't really notice the line is not straight, but I do notice the slight border on the left/right yes. I suppose it's a purely aestethic choice or does it have some functional reason too?

Some other comments:

  • I see some of the keys were renamed, which is okay but care has to be taken to do it consistently for all layers in the desktop layout then. Changing labels also makes it a bit harder to document keys clearly as the README refers to Cmp for example, I'd suggest not renaming these keys unless there's a good reason). I noticed:
    • "Cmp" changed to "><"
    • Sup changed to "<Arch logo>"; ideally I think we better keep a distro-neutral label in wvkbd rather than an Arch/Debian/Gentoo/.. logo (even though I too mostly use Arch, btw)
  • though 99% percent of desktop users are probably on a landscape layout, some 1% have a portrait monitor. The layout that opens then is still the same as in wvkbd-mobintl. Is this by choice? I'd be inclined to just use the same new landscape layout in portrait mode since the screen is probably wide enough on desktop.
  • Perhaps an AltGr key would be useful on the default layer (right of spacebar)? It would give alternative access to some special keys users may already be used too (and as an alterntive for Cmp).
  • Currently the keymaps and layouts for the other languages are still in the code, but not really modified. If they're not used they should be removed. Ideally though, a desktop layout for cyrillic etc would be great (if anyone's up for it).

Nice work!

--

Maarten van Gompel (proycon)

web: https://proycon.anaproy.nl gpg: 0x39FE11201A31555C

proycon avatar Mar 29 '24 22:03 proycon