goldensun_html5 icon indicating copy to clipboard operation
goldensun_html5 copied to clipboard

Glitchy walking animation next to buildings on displays with high refresh rates

Open MilesBHuff opened this issue 2 years ago • 9 comments

It doesn't show in screenshots; but walking just above the fence near Alex in the starting town results in a very strange walking animation. image

MilesBHuff avatar Apr 01 '22 03:04 MilesBHuff

Upon further investigation, this happens when next to anything that would block movement if walked into.

MilesBHuff avatar Apr 01 '22 03:04 MilesBHuff

Is it the same as #369 ?

jjppof avatar Apr 01 '22 12:04 jjppof

If it's not the issue, here is what I'm trying: bug2

jjppof avatar Apr 01 '22 12:04 jjppof

Not the same issue afaict (though maybe it's related?), and I don't see the issue in your gif; but it would probably require a 60fps animation to see. Screenshots only show intermediate positions, all of which look fine.

MilesBHuff avatar Apr 01 '22 14:04 MilesBHuff

Huh. I can't repro on my 60hz monitor. It happened last night, on a 300hz monitor. Maybe it only happens at high refresh rates?

MilesBHuff avatar Apr 01 '22 14:04 MilesBHuff

Oh yeah, that could be an issue. requestAnimationFrame follows monitor refresh rates. Sou you're probably running at 300 fps... Phaser 2 changed its fps engine at 2.17, so I need to better understand how to at least limit it to 60 fps... The only problem is that I don't have a high refresh rate monitor to see what's going on 😁

This is related to #338

jjppof avatar Apr 01 '22 15:04 jjppof

Got it! Well, if you need someone to test it, lmk! :)

MilesBHuff avatar Apr 01 '22 15:04 MilesBHuff

Sure, many thanks! I won't be able to release the engine without fixing this issue somehow... Will mark as duplicate.

jjppof avatar Apr 01 '22 16:04 jjppof

Duplicate of #338

jjppof avatar Apr 01 '22 16:04 jjppof