Jan Jones

Results 58 comments of Jan Jones

Local functions behave the same way (the default value is not propagated; see [SharpLab](https://sharplab.io/#v2:EYLgtghglgdgNAFxFANnAJiA1AHwAIBMABAMICwAUAN6VF1F4DMDAjAGwMAsRAKgKYBnBCwAUASlr0aFerKIA3CACciADyIBeIiPR8AxlEgoiAT03bdBo2JYA6FmM0A+IlQC+Abklyi3uXm5+IUYdfUMIYzMtUKsIm3tHdz83Sj8mVg4A3kEEAhjwyPN86zsHP2lZFIo3IA=)). Should they be fixed, too?

> What behavior you are referring to? I was referring to the fact that the implementation method of a local function doesn't have `DecimalConstantAttribute`, although it has other default values...

> Consider fixing this issue as well. I have included the fix in the PR.

> how we support this outside of code blocks in the parser today This problem really only appears inside code blocks. The parser consumes code, then encounters `

@JoeRobich I can repro this with `dotnet format` from SDK 8.0.200, but I don't think it's the same issue as https://github.com/dotnet/roslyn/issues/72015 (that one didn't ship in SDK 8.0.200). I also...

I completely agree with you - there appears to be a bug in dotnet format in 8.0.200 which makes it not work with the razor source generator. > Is there...

> But what you suggest is that the compiler generates this: That's not correct. The `Icon` is not a parameter like `[Parameter] public Type Icon { get; set; }` (if...

Thanks for reporting this issue. Try referencing NuGet package [SkiaSharp.Views.Blazor](https://www.nuget.org/packages/SkiaSharp.Views.Blazor): ```ps1 dotnet add package SkiaSharp.Views.Blazor ``` And please let me know how that works for you.

> I would expect that formatting of Razor components in the global namespace would not work. Is there something I should change to make it work?

Oh, so the concern is about indentation? Components in the global namespace are actually still indented as if they were emitted inside `namespace` block: https://github.com/dotnet/razor/pull/10086/files#diff-38349d3b6effd9eb09b5b2da2152117586045b6e2171fda332b593a705269ea5