Jan Jones

@dotnet/roslyn-compiler for a second review, thanks

Thanks for the detailed report. Looks like a duplicate of https://github.com/dotnet/roslyn/issues/71773 which we already have a fix PR open for. However, I might want to add some more tests based...

> we need to both set DOTNET_HOST_PATH and PATH accordingly Yes, but you can also just set PATH accordingly (pointing to the custom SDK first) and DOTNET_HOST_PATH can be unset,...

The problem is you removed the field `GeneratorDriverState.TrackIncrementalSteps`. Some older Razor compilers (including the one tested currently by the failing test) deploy its own ExternalAccess.RazorCompiler assembly which is compiled against...

> var src1 = @" In general, why are you not using raw string literals, at least for new tests? #Closed --- Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs:29 in 47bf749. [](commit_id = 47bf749773b240a4f1873c5097655b4b13e6ebab,...

> public void ConstructorSymbol_02([CombinatorialValues("class ", "struct")] string keyword) "class" (no trailing space) #Closed --- In reply to: [1346443971](https://github.com/dotnet/roslyn/pull/65899#issuecomment-1346443971) [](http://example.com/codeflow?ancestors=1346443971) --- Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs:404 in 47bf749. [](commit_id = 47bf749773b240a4f1873c5097655b4b13e6ebab, deletion_comment =...

> CompileAndVerify(comp, expectedOutput: "42").VerifyDiagnostics(); ; superfluous semicolon --- In reply to: [1346555551](https://github.com/dotnet/roslyn/pull/65899#issuecomment-1346555551) [](http://example.com/codeflow?ancestors=1346555551) --- Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs:2794 in 47bf749. [](commit_id = 47bf749773b240a4f1873c5097655b4b13e6ebab, deletion_comment = False)

> public void AttributesOnPrimaryConstructorParameters_09_CallerMemberName([CombinatorialValues("class ", "struct")] string keyword) Why 09 when the previous test is AttributesOnPrimaryConstructorParameters_02? --- In reply to: [1346564013](https://github.com/dotnet/roslyn/pull/65899#issuecomment-1346564013) [](http://example.com/codeflow?ancestors=1346564013) --- Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs:2895 in 47bf749. [](commit_id =...

> Assert.Equal(0, analyzer.FireCount3); Consider adding comments to places where fire counts are zero. At least, I don't understand why is that the case. #Closed --- Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs:3403 in 47bf749....

@dotnet/roslyn-compiler for the second review