internetarchive
internetarchive copied to clipboard
jjjake
enable .json formats for uploading and metadata editing
it's a small edit of mine: i was having problems uploading files since it has commas on it. instead of fixing it with double quotes, i just tried editing the code. just a small one.
what it does is it checks *.json in the filename, else it's a *.csv. that's pretty much it.
Additionally to the previously suggested changes, you should definitely amend the first line of your commit to something more descriptive than First Commit.
I also don't really like these changes since a JSON file is not a spreadsheet. So the functionality should probably be separate from --spreadsheet and e. g. have a --json equivalent.
Thanks for the contribution @laptopsftw, and thanks for reviewing @maxz!
I agree with all of @maxz's suggestions. Happy to merge once these are resolved. Thanks again.
Frankly, I do not understand how the recent review activity on this pull request was motivated.
To me it seems like @laptopsftw does not have too much interest in integrating this pull request or else they would at least have notified us that they are working on the changes (unless something major in their life came up which hindered them).
Frankly, I do not understand how the recent review activity on this pull request was motivated.
To me it seems like @laptopsftw does not have too much interest in integrating this pull request or else they would at least have notified us that they are working on the changes (unless something major in their life came up which hindered them).
honestly i was still on the edge of actually integrating it on the mainline, since .csv was already a good workaround for this and it's just me being dum dum (unfamiliar) with the file format.
as for me i have a separate local fork working for my case. would try to update a new pull request if i started working for 3.0.0 (i'm still uploading my files in 2.1.0 atm)