pychemqt icon indicating copy to clipboard operation
pychemqt copied to clipboard

cleanup modules checking code

Open AhmadAlsaadi opened this issue 8 years ago • 4 comments

dear JJgomera, I thing this project is quite interesting and I would like to contribute to it. Even though I do not think that I will having much time to contribute regularly to it but I will try to do my best. Below is little description about my first pull request:

I did two things in this pull request: first I was getting error when I run the program "it is about the global variable in the mainWindow.py file. I went around this error be commenting the global variable there.

second: I tried to shorten the code for checking required and optional modules in pychemqt file. I used the same procedure that used for the optional modules for the required modules. I modified the name of set in the tool.depences file from optional_modules to external_modules because I added to this set the data for the required modules. I did not delete the old code and just comment it and labeled it with "not required anymore"

please let me know if you need further details.

AhmadAlsaadi avatar Nov 09 '17 02:11 AhmadAlsaadi

Coverage Status

Coverage remained the same at 24.579% when pulling d7b0cef7cff0209436bcc6af17533ad0391d2b6b on AhmadAlsaadi:code_cleanup into e048915d151e1688856157184e9fc7376ca3c9b2 on jjgomera:master.

coveralls avatar Nov 09 '17 02:11 coveralls

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   36.01%   36.01%           
=======================================
  Files         226      226           
  Lines       32187    32187           
=======================================
  Hits        11591    11591           
  Misses      20596    20596

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e048915...d7b0cef. Read the comment docs.

codecov-io avatar Nov 09 '17 02:11 codecov-io

@AhmadAlsaadi Thanks for this pull request. I think this project is interesting also. Is it possible for me to develop/test based on this branch?

Jeroendevr avatar Apr 30 '18 13:04 Jeroendevr

Yes sure.

On Mon, 30 Apr 2018, 16:24 Jeroendevr, [email protected] wrote:

@AhmadAlsaadi https://github.com/AhmadAlsaadi Thanks for this pull request. I think this project is interesting also. Is it possible for me to develop/test based on this branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jjgomera/pychemqt/pull/14#issuecomment-385396857, or mute the thread https://github.com/notifications/unsubscribe-auth/AMiQteg-tnRKST6zm_vt5nC540LUD6fqks5ttxB7gaJpZM4QXV1T .

--

This message and its contents, including attachments are intended solely for the original recipient. If you are not the intended recipient or have received this message in error, please notify me immediately and delete this message from your computer system. Any unauthorized use or distribution is prohibited. Please consider the environment before printing this email.

AhmadAlsaadi avatar Apr 30 '18 20:04 AhmadAlsaadi