Julien Jerphanion
Julien Jerphanion
> I started writing some code to get a feeling for what a "plugin system" based on pluggy would look like (code over architecture docs). I already learnt a lot...
Thanks, I just pasted your snippet in the description to replace the text.
Regarding dtype preservation for fitted attributes, wouldn't it be better to introduce global checks for it with tags? I feel that we might spend a lot of time duplicating checks...
@adam2392: some estimators aren't preserving the provided input dtype. In that case, it still makes sense to extend the tests adding TODO, as explained in the description of this issue:...
@lucyleeow: can you try merging `main` in your branch?
Hi @lucyleeow. In my opinion, this example has a clear advantage over a blog post as it provides code snippets with explanations users can start from and build their use-cases...
> A blog post or similar can have code examples too? Yes it can, but aren't examples better suited for maintenance? > [...] but I do agree with what's been...
> I think just that our examples don't usually look at methods implemented outside of sklearn (though not sure if this is what others in the thread above mean) To...
I pushed to add the last fixes on `main` solving (some of) the problems on the CI.
Circle CI builds with Python 3.10 which is [unsupported for `llvm-lite`](https://github.com/numba/llvmlite/blob/c8158042c8015cad7c7d6ba1eb7143fca0d3a9d1/setup.py#L36), hence causing the CI to fail. One way to get around this problem would be to pin the version...