JJazzLab icon indicating copy to clipboard operation
JJazzLab copied to clipboard

Add markers for each song part in exported Midi file

Open jjazzboss opened this issue 4 years ago • 2 comments

Marker will be the song part name.

jjazzboss avatar Feb 08 '21 18:02 jjazzboss

I'm new doing contributions to open-source projects and I think this could be a good first task, can you assign this to me?

lezhdz98 avatar Jan 02 '25 23:01 lezhdz98

Yes thanks. You should create a pull request on the dev branch, the one I'm using for 4.1.3.

Some pointers:

https://github.com/jjazzboss/JJazzLab/blob/dev/core/RhythmMusicGeneration/src/main/java/org/jjazz/rhythmmusicgeneration/api/SongSequenceBuilder.java#L307

used by

https://github.com/jjazzboss/JJazzLab/blob/master/core/MusicControl/src/main/java/org/jjazz/musiccontrol/api/SongMidiExporter.java#L124

jjazzboss avatar Jan 03 '25 16:01 jjazzboss

I don't see a fork from lezhdz98 nor merged PR for this so I'll give it a crack.

I want to update the dev docs a bit first in the process, sending an email to contact(at)jjazzlab regarding that.

juanotto avatar Sep 02 '25 06:09 juanotto

@juanotto I marked a few other issues as "good first issue", if ever you want to continue to discover jjazzlab internals 👍

jjazzboss avatar Sep 07 '25 13:09 jjazzboss