lib-jitsi-meet icon indicating copy to clipboard operation
lib-jitsi-meet copied to clipboard

selectEndpoints with no selected endpoints should remove previously selected endpoint

Open maxired opened this issue 2 years ago • 1 comments

Description

When creating an application directly with the lib and on top jitsi-meet, I should be able to remove all participants from the selectedEndpoints

Current behavior

when calling selectEndpoints with an empty array, a previously selected participants is still prioritised

Expected Behavior

when calling selectEndpoints with an empty array, no participants should be priorisited

Possible Solution

the selectEndpoints method should remove check about !this._selectedEndpoints.length and the constraints getter should return the default constraints instead of the previous one.

Steps to reproduce

Given a running conference running with the lib,

  • call selectParticipants on the conference object with an array containing a single participant : participants are selected
  • then call selectParticipants with an empty array: Participant are still selected.

note: I also do not understand why when multiple participants are selected, we don't seem to send the list of selected participants. see here

maxired avatar Oct 18 '22 15:10 maxired

If you want to receive no one you can set last N to zero.

saghul avatar Nov 15 '22 09:11 saghul