lib-jitsi-meet icon indicating copy to clipboard operation
lib-jitsi-meet copied to clipboard

Published 20 hours ago • verified publisher icon jitsi

feat(ScreenObtainer): add support for tab capture on Electron

Open DanielMcAssey opened this issue 3 years ago • 4 comments

With https://github.com/electron/electron/pull/31204 being merged into Electron and released with Electron 17.x.x, Electron can now capture individual WebContents (Tabs). This change allows the standard flow to support tab capture

DanielMcAssey avatar Feb 06 '22 11:02 DanielMcAssey

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Feb 06 '22 11:02 jitsi-jenkins

But how to "tabs" manifest on Electron? Like Chrome tabs?

saghul avatar Feb 06 '22 14:02 saghul

Essentially yeah, so you can have a BrowserWindow with different WebContents (Tabs), in addition capturing the WebContents also removes the Window Frame

DanielMcAssey avatar Feb 06 '22 19:02 DanielMcAssey

I see. We need to make sure this does not break existing apps before landing it though.

saghul avatar Feb 07 '22 08:02 saghul