lib-jitsi-meet icon indicating copy to clipboard operation
lib-jitsi-meet copied to clipboard

feat: disableScreenshareSimulcast

Open psi-4ward opened this issue 4 years ago • 3 comments

We have a use case where it makes sense to have simulcast for Webcams enabled but not for screenshares. Are you open for a PR with an config option to disable simulcast for screenshares and setting it's bitrate? Like a follow up for unclear capScreenshareBitrate?

    desktopSharingFrameRate: {
         max: 30
    },
    desktopShareBitrate: 2e6,
    disableSimulcastScreenshare: true,

psi-4ward avatar Apr 29 '21 19:04 psi-4ward

Yes, we would be open to a PR that provides the ability to control simulcast and bitrate for screenshare. capScreenshareBitrate was introduced as part of A/B testing effort when we started seeing issues with simulcast screenshare and it didn't make sense to continue using it.

jallamsetty1 avatar Apr 29 '21 21:04 jallamsetty1

Nice.

Do you think there are any reasons to use simulcast for screenshare but not for video?

psi-4ward avatar Apr 29 '21 21:04 psi-4ward

Nice.

Do you think there are any reasons to use simulcast for screenshare but not for video?

Nope.

jallamsetty1 avatar Apr 30 '21 20:04 jallamsetty1