lib-jitsi-meet icon indicating copy to clipboard operation
lib-jitsi-meet copied to clipboard

feat: revoke owner from a participant

Open zWaR opened this issue 4 years ago • 3 comments

Proposing a MR with a new feature of revoking ownership from a participant. The added method is a counterpart of grantOwner and is helpful when the affiliation is being changed while participants are already in the conference.

zWaR avatar Oct 07 '20 02:10 zWaR

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Oct 07 '20 03:10 jitsi-jenkins

CLA Signed

zWaR avatar Oct 07 '20 03:10 zWaR

Hey everyone,

I was thinking about this PR and perhaps it'd be good to give you a bit of a context as of why we're committing this. In our case we developed our own Prosody plugin to handle authorization of the conference participants. In our UI we allow elevated users to set affiliation for other participants . Granting ownership is straight forward, since lib-jitsi-meet features JitsiConference.grantOwner() method which we use. Revoking ownership however is not as straight forward and required us to implement logic on the Prosody plugin to accomplish it. With a JitsiConference.revokeOwner method we'd not need to handle ownership revocation in the Prosody plugin anymore, but instead simply use a call via lib-jitsi-meet just like we do for granting the ownership. This would simplify the plugin code and make the overall solution more robust.

Hopefully you find value in adding a feature like that to your code base. Of course any comments or questions are welcome.

zWaR avatar Oct 12 '20 21:10 zWaR