jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

[Feature] Disable audio processing option in apps

Open lucaslcode opened this issue 4 years ago • 40 comments

You can disable audio processing using #config.disableAP=true in Chrome, but not the apps (or firefox).

I don't know if the apps support setting config like this in general, but it appears according to this bit of the jitsi js library that there's something in react-native webRTC library preventing this?

Running chrome on devices and using 'view desktop site' works, but isn't ideal and can crash occasionally.

If this could be implemented, it would be the only app that can do this on mobile as far as I know - only Zoom has the option, and only on Desktop. The many music teachers giving remote lessons right now like me would love this feature!

lucaslcode avatar Mar 29 '20 15:03 lucaslcode

Can you please clarify why this would be useful in that scpecific scenario, on mobile?

saghul avatar Mar 29 '20 18:03 saghul

For example, I am teaching many violin students now with Zoom or Jitsi. WIth audio processing, a long note on the violin gets caught in the noise cancellation and becomes garbled or muted.

I turn it off for myself, but if they are using a tablet or phone, they don't have a way to turn it off.

Actually, an option for the host to disable the audio processing for everyone would be amazing, but I imagine that's a lot more work to implement.

lucaslcode avatar Mar 29 '20 20:03 lucaslcode

I see now. I'm not sure how we could accomplish that, but let's keep it open and I'll take a look as time allows.

saghul avatar Mar 30 '20 11:03 saghul

Hi, would this allow to mix all sounds without priority or filter? That's a feature we'd like to have for choir rehersals! Having each one sing without listening to others is very painful with all visio applications made for speech.

jcm avatar Apr 04 '20 08:04 jcm

@lucaslcode @saghul I am trying to build a videoconferencing platform too for music teachers and they complain a lot about audio processing/noise cancellation when using GoogleHangout, Zoom, Skype etc.. For musicians it would be a powerful tool if you could just send the raw audio input. For really high sound quality it also would be nice to use the maximum available bandwith right? Please let me know if there is any option with Jitsi of deactivating the audio processing. Thx!

sebo361 avatar Apr 05 '20 17:04 sebo361

Can you please clarify why this would be useful in that scpecific scenario, on mobile?

This is important to practically everyone who plays musical instruments: Music teachers, students, performers, composers, social musicians... I know dozens of them personally, and Zoom is currently the only service most of them will use, because it's easy to use and (critically) has the options they need to deliver the music properly.

I got one such group to try Jitsi Meet recently, but they quickly found that the sound quality was not good enough, and returned to Zoom. It seems like Jitsi could become relevant in this space simply by exposing the appropriate config controls, such as disabling audio processing and limiting video bandwidth. Ideally, a conference organizer would be able to choose the appropriate settings globally, to relieve individual participants from configuration hassles. (Musicians are not famously skilled or patient with multimedia network software troubleshooting.)

Please consider this a +1. (Or maybe a +30, if you count the musicians in my life. This demographic is easily overlooked, because few of them participate in software development channels, yet most of them depend on software.)

foresto avatar Apr 08 '20 20:04 foresto

Thanks for your comment and well explained @foresto ! There are platforms like playwithapro.com/ or appassio.com/ which offer video conferencing for online teaching with a focus on high quality audio transmission, but cost a lot of money (around 200-500€/month). There are at least 50+ musicians + a music academy who is interested in a new solution with advanced audio transmission. If somebody knows how to make audio settings accessible in Jitsi, please let me know.

sebo361 avatar Apr 08 '20 20:04 sebo361

Just to clarify, you can disable audio processing right now in Jitsi Meet. Just add #config.disableAP=true to your meeting link. It will work in any chrome browser, but not in the apps or firefox.

On Wed, 8 Apr 2020 at 21:46, sebo313 [email protected] wrote:

Thanks for your comment and well explained @foresto https://github.com/foresto ! There are platforms like playwithapro.com/ https://www.playwithapro.com/ or appassio.com/ which offer video conferencing for online teaching with a focus on high quality audio transmission, but cost a lot of money (around 200-500€/month). There are at least 50+ musicians + a music academy who is interested in a new solution with advanced audio transmission. If somebody knows how to make audio settings accessible in Jitsi, please let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jitsi/jitsi-meet/issues/5462#issuecomment-611185375, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUPIP6BDBCD4MVOGHHML4DRLTPARANCNFSM4LWATDRQ .

lucaslcode avatar Apr 09 '20 17:04 lucaslcode

Just to clarify, you can disable audio processing right now in Jitsi Meet. Just add #config.disableAP=true to your meeting link. It will work in any chrome browser, but not in the apps or firefox. On Wed, 8 Apr 2020 at 21:46, sebo313 @.***> wrote: Thanks for your comment and well explained @foresto https://github.com/foresto ! There are platforms like playwithapro.com/ https://www.playwithapro.com/ or appassio.com/ which offer video conferencing for online teaching with a focus on high quality audio transmission, but cost a lot of money (around 200-500€/month). There are at least 50+ musicians + a music academy who is interested in a new solution with advanced audio transmission. If somebody knows how to make audio settings accessible in Jitsi, please let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5462 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUPIP6BDBCD4MVOGHHML4DRLTPARANCNFSM4LWATDRQ .

Hi @lucaslcode thanks for the info. I already tried to set #config.disableAP=true in Google Chrome browser but it disables all audio processing right? Without talking or music at all, there was a lot of echo in our session which made it impossible to use it. So rather having no audio processing at all, it should be a music-opttimized audio processing instead of speaker-optimized audio processing ...

sebo361 avatar Apr 11 '20 12:04 sebo361

@sebo313 You could try the more specific options: disableAEC - Auto echo cancellation disableAGC - auto gain control disableAP - all audio processing disableHPF - high pass filter disableNS - noise supression

so I imagine you want #config.disableHPF=true&config.diableNS=true&config.disableAGC=true

On Sat, 11 Apr 2020 at 13:55, sebo313 [email protected] wrote:

Just to clarify, you can disable audio processing right now in Jitsi Meet. Just add #config.disableAP=true to your meeting link. It will work in any chrome browser, but not in the apps or firefox. … <#m_-7781384917076409945_> On Wed, 8 Apr 2020 at 21:46, sebo313 @.***> wrote: Thanks for your comment and well explained @foresto https://github.com/foresto https://github.com/foresto ! There are platforms like playwithapro.com/ https://www.playwithapro.com/ or appassio.com/ which offer video conferencing for online teaching with a focus on high quality audio transmission, but cost a lot of money (around 200-500€/month). There are at least 50+ musicians + a music academy who is interested in a new solution with advanced audio transmission. If somebody knows how to make audio settings accessible in Jitsi, please let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5462 (comment) https://github.com/jitsi/jitsi-meet/issues/5462#issuecomment-611185375>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUPIP6BDBCD4MVOGHHML4DRLTPARANCNFSM4LWATDRQ .

Hi @lucaslcode https://github.com/lucaslcode thanks for the info. I already tried to set #config.disableAP=true in Google Chrome browser but it disables all audio processing right? Without talking or music at all, there was a lot of echo in our session which made it impossible to use it. So rather having no audio processing at all, it should be a music-opttimized audio processing instead of speaker-optimized audio processing ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jitsi/jitsi-meet/issues/5462#issuecomment-612415153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUPIP4OYXLAZMFBYZ3TT2DRMBSEBANCNFSM4LWATDRQ .

lucaslcode avatar Apr 11 '20 13:04 lucaslcode

Dear Lucaslcode, i am a music teacher and our school uses google meet for online lessons. It would be very helpful to me to disable audio processing. I have read your suggestion "Just add #config.disableAP=true to your meeting link." but I cannot understand how to do it. In meet there is an automatic invitation feature that sends an email to the students to invite them, so I shall need to know how to solve the problem. Sorry but I am not a informatico pro :) and thank you.

Edobruni avatar May 25 '20 08:05 Edobruni

@Edobruni Are you not using Jitsi Meet?

luixxiul avatar May 25 '20 08:05 luixxiul

nope, I use google meet. We must use that for school. I thought it was the same, but now I suppose it is not.....

Edobruni avatar May 25 '20 09:05 Edobruni

No, Jitsi Meet and Google Meet is completely different software. For Google Meet, you would need to consult with Google's support site.

luixxiul avatar May 25 '20 09:05 luixxiul

Sorry guys, I read "meet" and "chrome" and I thought it was google meet. I apologize for messing up in the topic :) Kind regards and best wishes.

Edobruni avatar May 25 '20 09:05 Edobruni

That will make Jitsi the greatest forever for music teachers.

Is there a technical limitation for mobile phones that the options of disabling audio processing is not possible in native app, or is it just not implemented?

Neither Zoom nor www.playwithapro.com provides that option, and in playwithapro.com it says that it supports mobile phone client as long as they use Chrome browser. To met, it seems like there are technical reasons but if there really is, I don't quite understand. What is the difference comparing to other apps that just records audio through the mic?

goldyliang avatar Jul 31 '20 08:07 goldyliang

I tried the audio setting like this today in meetings using Chrome, but I dont hear the difference. How to effectiently test if the options work?

And for meetings with 8x8,vc is these options also available?

goldyliang avatar Jul 31 '20 22:07 goldyliang

Hi @goldyliang @Edobruni @luixxiul , i set up the music optimized video conferencing platform https://sirius.video/. Just drop me an email to [email protected] and I will give you free access. Also we are working on an even better music optimized solution with very low latency (70ms - 100ms) - stay tuned!

sebo361 avatar Aug 03 '20 10:08 sebo361

@sebo361 that's great! It would be good, especially for credibility / clarity / trust etc. to explicitly mark that your instance is a music-optimized Jitsi. You'd want most bug-reports and other things to go directly here. If you could also put your fork (or tweaks or whatever it is) up on GitHub (or maybe GitLab or SourceHut or other place), that would allow others to submit patches or otherwise contribute.

wolftune avatar Aug 04 '20 04:08 wolftune

@sebo361 , personally I agree with @wolftune , unless your project is going to be purely commercial. I also thought of ideas of this or that improvement, but I found it not easy without community support.

goldyliang avatar Aug 04 '20 04:08 goldyliang

@goldyliang That's not necessarily a conflict, people run commercial services hosting fully free/libre/open (FLO) software. It can be both FLO and commercial without any compromises. I'd most hope that feature updates get pushed upstream to Jitsi itself whenever feasible.

wolftune avatar Aug 04 '20 04:08 wolftune

@wolftune @goldyliang My current beta version is non-commercial and freely available to everyone interested. Besides disabling audio filters, as recommended in previous posts, I have set up Jitsi (according to the setup instructions) on an own server, which helps to ensure a stable connection. You can check the detailed settings via "Inspect" on my website. The new version I am currently working on is not based on Jitsi and will be much more optimized for music in terms of audio quality and features. I will let you know when its ready.

sebo361 avatar Aug 04 '20 10:08 sebo361

@sebo361 thanks, that sounds pretty intriguing. I hope you will make your new product still free/libre/open and fully privacy respecting.

On a side-note about Jitsi specifically: I've used some other systems like Big Blue Button and had different sorts of glitches. With Jitsi, the audio and video can get really off from each other. And somehow with BBB that never ever happens.

UPDATE: after I first posted this, something was improved, I've not experienced this in a long time, I think it's fully fixed.

wolftune avatar Aug 04 '20 16:08 wolftune

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 07 '20 06:11 stale[bot]

We're still here, stalebot.

foresto avatar Nov 07 '20 08:11 foresto

Hello, any updates on this issue ?

finaldzn avatar Apr 14 '21 15:04 finaldzn

No news, sorry. Last I looked into this it's tricky because disabling the AEC and NS would require an app restart on Android, for example.

That said, any patches are very welcome, I'll be happy to help review / land them.

saghul avatar Apr 14 '21 15:04 saghul

No news, sorry. Last I looked into this it's tricky because disabling the AEC and NS would require an app restart on Android, for example.

That said, any patches are very welcome, I'll be happy to help review / land them.

Hi @saghul , this is interesting, how did you achieve that ? configuration or custom code ?

Can't find the right place to do it

oliviercafe avatar May 19 '21 14:05 oliviercafe

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 13:01 stale[bot]

I think this problem still exists. Please don't close the report, annoying bot.

foresto avatar Jan 09 '22 20:01 foresto