jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

fix(carmode) Force portrait when in carmode

Open horymury opened this issue 2 years ago • 1 comments

horymury avatar Sep 19 '22 15:09 horymury

Left some comments, PTAL

@saghul addressed.

horymury avatar Sep 21 '22 10:09 horymury

@horymury this merge added wonday/react-native-orientation-locker which not stable I think. when my app using sdk build with this feature running on Samsung device will got crash right after join room because https://github.com/wonday/react-native-orientation-locker/issues/206

quyenvsp avatar Oct 21 '22 17:10 quyenvsp

What commit did you build? We have fixed that issue on our end.

saghul avatar Oct 22 '22 10:10 saghul

Yeah thank you so much for information, I uasually use Stable tag. so latest is stable/jitsi-meet_7882. I am going to use master now 👍

quyenvsp avatar Oct 22 '22 12:10 quyenvsp

Stable tags are for the web, they are not mobile stable.

We just released a stable SDK with the tag android-sdk-6.2.1 it's got an annoying bug which we'll fix on Monday though 😅

saghul avatar Oct 22 '22 13:10 saghul