jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

showNotification command not available

Open bogdanghervan opened this issue 2 years ago • 6 comments

We are trying to use the newly released command showNotification (#11897) but our loaded version of the Jitsi Iframe API (JaaS) does not seem to contain it.

We see a "Not supported command name." error message in the console.

image

The 6380.3155 version seems to be loaded from the CDN. Should I assume this new feature was not yet made available for JaaS or is there a way to force this new version to be loaded?

bogdanghervan avatar Aug 06 '22 12:08 bogdanghervan

It's not yet released for JaaS (jitsi-meet changelog for the latest release).

mihhu avatar Aug 06 '22 13:08 mihhu

Thanks @mihhu. When is showNotification expected to be released?

Generally speaking, is there a way to tell if the commands documented in the handbook would work with JaaS or not?

So far I couldn't get sendChatMessage, kickParticipant and askToUnmute to work, but I suspect others don't work as well (displayName or grantModerator).

bogdanghervan avatar Aug 06 '22 14:08 bogdanghervan

Thanks @mihhu. When is showNotification expected to be released?

I can't say for sure, but most probably next month at the latest.

Generally speaking, is there a way to tell if the commands documented in the handbook would work with JaaS or not?

Currently there isn't, newly added features get documented asap, because they become available for those forking the repo. However, it's a good idea to mark the ones that aren't yet available in JaaS. @saghul, maybe we can use a badge the way we do for deprecated options, wdyt?

So far I couldn't get sendChatMessage, kickParticipant and askToUnmute to work, but I suspect others don't work as well (displayName or grantModerator).

Usually it's the new features that take a while to catch the release, the ones you mentioned are quite old now, they should work (can't test atm). Could you please share a snippet?

mihhu avatar Aug 06 '22 14:08 mihhu

Not sure TBH I have the feeling it could go out of sync easily.

saghul avatar Aug 06 '22 17:08 saghul

Might it help if there was a api.getSupportedCommands() and api.getSupportedEvents() function? It would make it easier for devs to inspect what commands/events are available for the version they are using.

As a bonus it also makes it possible to programmatically infer if a command is available and fallback to some alternative mechanism if it were not.

shawnchin avatar Aug 08 '22 11:08 shawnchin

That's not a bad idea!

saghul avatar Aug 08 '22 11:08 saghul

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 31 '23 01:08 github-actions[bot]

Fixed in https://github.com/jitsi/jitsi-meet/pull/12011

saghul avatar Sep 08 '23 07:09 saghul