jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

fix: display dial-in code on a new line

Open TBG-FR opened this issue 2 years ago • 1 comments

Issue

In the "invite people" modal, the phone number and the PIN code are displayed on the same line. It causes the PIN code to break in the middle, misleading people when they try to join a conference by phone.

Changes

A very small change, to add a line break between phone number and PIN code

See it in action

Before

image

After

image

TBG-FR avatar Aug 04 '22 16:08 TBG-FR

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Aug 04 '22 16:08 jitsi-jenkins

Hey @damencho or @bgrozev or @saghul , could you review and accept that small modification ? It's a little thing, but a lot of users are misled and do not type all numbers of the PIN code...

Thanks in advance 🙏 have a nice day 😄

TBG-FR avatar Apr 30 '23 11:04 TBG-FR

This file no longer exists.

damencho avatar May 02 '23 11:05 damencho

This file no longer exists.

Yep it was renamed to DialInNumber.tsx. But the same fix can be applied on the new file.

horymury avatar May 02 '23 11:05 horymury

Can you apply the fix pl? We let this one slide for months...

saghul avatar May 02 '23 12:05 saghul

Can you apply the fix pl? We let this one slide for months...

Created new PR . Closing this one

horymury avatar May 02 '23 12:05 horymury

Addressed in a new PR

horymury avatar May 02 '23 12:05 horymury

Thanks a lot guys 🙏 (for reference : #13309 )

TBG-FR avatar May 02 '23 14:05 TBG-FR